feat(theme): Aurora routes — batch multi-select (parity with pro/default) - #168
Merged
Merged
Conversation
…ult) Aurora already had the batch bar + actions markup and the shared batch JS, but was missing the trigger button and the table checkbox column, so batch mode could never be entered. Completes it: - routes.njk: add the #btn-batch-routes trigger to the page actions. - auroraRenderTableRow: prepend a .batch-checkbox cell in batch mode. - auroraRenderTable: prepend the batch <th>, add .batch-mode table class, and widen the group-header colspan (6→7) so headers still span the full row. - aurora.css: .data-table .td-batch / .batch-checkbox styling + batch-mode row cursor. - layout.njk: add the batch.* GC.t keys (selected/none_selected/enable/disable/ delete/confirm_delete_routes) so the count labels localize (de/en) instead of falling back to the English JS defaults — a gap pro/default still have. Aurora-only; shared batch JS + /api/routes/batch unchanged. Verified headless: checkboxes appear, row-click toggles selection + count, enable/disable/delete + cancel work, no JS errors; aurora_theme.test 144/0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auf deinen Wunsch: die Batch-Mehrfachauswahl gibt es jetzt auch im Aurora-Theme.
Ausgangslage
Aurora hatte die Batch-Leiste + Aktionen-Markup und die geteilte Batch-JS bereits — es fehlten nur der Auslöse-Button und die Checkbox-Spalte in der Tabelle, daher ließ sich der Batch-Modus nie aktivieren.
Ergänzt
routes.njk:#btn-batch-routes-Button in den Page-Actions.auroraRenderTableRow:.batch-checkbox-Zelle (erste Spalte) im Batch-Modus.auroraRenderTable: Batch-<th>,.batch-mode-Tabellenklasse, Gruppenkopf-colspan6→7.aurora.css:.td-batch/.batch-checkbox-Styling + Zeilen-Cursor.layout.njk:batch.*-GC.t-Keys ergänzt, damit die Zähl-Labels lokalisiert sind (de/en) — statt der englischen JS-Fallbacks, die Pro/Default noch haben.Verifikation (headless-chromium, 13 Assertions)
Checkboxen erscheinen (6 Zeilen) · Button versteckt + Bar sichtbar im Batch-Modus · Zeilen-Klick toggelt Auswahl + Zähler · Enable/Disable/Delete-Labels mit Count · Cancel verlässt den Modus · echte Disable-Aktion läuft durch · keine JS-Fehler ·
aurora_theme.test144/0.Aurora-only; geteilte Batch-JS +
/api/routes/batchunverändert.