fix(theme): Aurora RDP 'Add route' modal — load form-logic scripts, style selectors, fix duplicate - #174
Merged
Conversation
…tyle selectors, fix dup The Add/Edit RDP modal was broken in Aurora: protocol switching didn't change fields, the protocol/auth selectors were unstyled, and the modal felt slow. Root cause: aurora/pages/rdp.njk only loaded /js/rdp.js but NOT /js/rdp-form-logic.js (defines window.GCRdpForm) or /js/rdp-cred-omission.js. rdp.js calls GCRdpForm.* for protocol→fields visibility, step navigation, default ports and validation, so every interaction threw and the form was non-functional. Added both scripts (matches pro). Also: - Added CSS for the .rdp-proto-seg/.rdp-proto-opt and .rdp-auth-seg/.rdp-auth-opt segmented controls (none existed in any theme); active option now highlights. - Removed a duplicate #rdp-ssh-auth-seg block (invalid duplicate id) left over in the auth step; kept the #rdp-ssh-auth-mode-wrapped one rdp.js drives. Aurora-only. Verified headless: GCRdpForm present, modal opens ~0.4s, protocol switch changes port (rdp 3389 / ssh 22 / vnc 5900) + active state, step nav works, Save + review appear only on the final (review) step, no page errors. aurora_theme.test 144/0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Das „Add RDP Route"-Modal war im Aurora-Theme defekt: Protokoll-Wechsel (RDP/VNC/SSH/Telnet) änderte die Felder nicht, die Auswahl-Buttons waren ungestylt, und das Modal wirkte langsam.
Root-Cause
aurora/pages/rdp.njklud nur/js/rdp.js, aber nicht/js/rdp-form-logic.js(definiertwindow.GCRdpForm) und/js/rdp-cred-omission.js.rdp.jsruftGCRdpForm.*für Protokoll→Feld-Sichtbarkeit, Schritt-Navigation, Default-Ports und Validierung — ohne das Modul warf jede Interaktion → Formular nicht funktionsfähig + träge. Beide Scripts ergänzt (wie Pro).Weiter
.rdp-proto-seg/.rdp-proto-optund.rdp-auth-seg/.rdp-auth-optergänzt (existierte in keinem Theme) — aktive Option wird hervorgehoben.#rdp-ssh-auth-seg(ungültige Duplikat-ID) im Auth-Schritt entfernt; die vonrdp.jsgesteuerte#rdp-ssh-auth-mode-Variante bleibt.Verifikation (headless, 13 Assertions)
GCRdpFormvorhanden · Modal öffnet ~0,4s · Protokoll-Wechsel ändert Port (rdp 3389 / ssh 22 / vnc 5900) + Active-State · Schritt-Navigation funktioniert · Save + Review erst auf dem letzten (Review-)Schritt · keine JS-Fehler.aurora_theme.test144/0.