Skip to content

chore(deploy): prune dangling images after a successful auto-update #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CallMeTechie merged 1 commit into from
Jun 24, 2026
Merged

chore(deploy): prune dangling images after a successful auto-update #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/services/systemSetup/templates/update.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,14 @@ ensure_guacd() {
)
}

prune_images() {
# Reclaim disk after a successful update: each :latest pull leaves the previous
# image dangling. Without pruning the host fills up over time (incident
# 2026-06-23: 187 images → root fs 100% → pulls failed → auto-update stalled).
# -f removes ONLY dangling (untagged) images, so tagged/in-use images are safe.
docker image prune -f >>"$LOG" 2>&1 || true
}

needs_update() { # echoes "yes" if running image != :latest
local latest running
latest="$(docker image inspect "$IMAGE" --format '{{.Id}}' 2>/dev/null || true)"
Expand All @@ -116,7 +124,7 @@ if [ "$MODE" = "manual" ]; then
err) log "could not resolve :latest digest"; write_state failed manual; exit 1 ;;
esac
log "manual trigger — recreating"
if recreate; then ensure_guacd || true; write_state updated manual; else log "recreate/health failed"; write_state failed manual; exit 1; fi
if recreate; then ensure_guacd || true; prune_images || true; write_state updated manual; else log "recreate/health failed"; write_state failed manual; exit 1; fi
exit 0
fi

Expand All @@ -128,4 +136,4 @@ case "$(needs_update)" in
err) log "could not resolve :latest digest"; write_state failed auto; exit 1 ;;
esac
log "auto: update needed — recreating"
if recreate; then ensure_guacd || true; write_state updated auto; else log "recreate/health failed"; write_state failed auto; exit 1; fi
if recreate; then ensure_guacd || true; prune_images || true; write_state updated auto; else log "recreate/health failed"; write_state failed auto; exit 1; fi
12 changes: 10 additions & 2 deletions update.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,14 @@ ensure_guacd() {
)
}

prune_images() {
# Reclaim disk after a successful update: each :latest pull leaves the previous
# image dangling. Without pruning the host fills up over time (incident
# 2026-06-23: 187 images → root fs 100% → pulls failed → auto-update stalled).
# -f removes ONLY dangling (untagged) images, so tagged/in-use images are safe.
docker image prune -f >>"$LOG" 2>&1 || true
}

needs_update() { # echoes "yes" if running image != :latest
local latest running
latest="$(docker image inspect "$IMAGE" --format '{{.Id}}' 2>/dev/null || true)"
Expand All @@ -116,7 +124,7 @@ if [ "$MODE" = "manual" ]; then
err) log "could not resolve :latest digest"; write_state failed manual; exit 1 ;;
esac
log "manual trigger — recreating"
if recreate; then ensure_guacd || true; write_state updated manual; else log "recreate/health failed"; write_state failed manual; exit 1; fi
if recreate; then ensure_guacd || true; prune_images || true; write_state updated manual; else log "recreate/health failed"; write_state failed manual; exit 1; fi
exit 0
fi

Expand All @@ -128,4 +136,4 @@ case "$(needs_update)" in
err) log "could not resolve :latest digest"; write_state failed auto; exit 1 ;;
esac
log "auto: update needed — recreating"
if recreate; then ensure_guacd || true; write_state updated auto; else log "recreate/health failed"; write_state failed auto; exit 1; fi
if recreate; then ensure_guacd || true; prune_images || true; write_state updated auto; else log "recreate/health failed"; write_state failed auto; exit 1; fi
Loading