fix(domains): skip non-public-TLD bases in boot seeding + prune lingering pending rows - #186
Merged
Merged
Conversation
…ring pending rows Non-public bases (.internal/.lan/...) can never verify against public DNS, so they lingered as permanent 'pending' noise on the Domains page once B made them visible. Now they are never seeded, and existing auto-seeded pending non-public rows are pruned on boot. Verified rows are never touched; routes read routes.domain directly and nothing FKs to the domains table. Follow-up to the A→C→B domain initiative (B = PR #185).
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A-Folge-Fix: nicht-öffentliche Basen nicht ins Boot-Seeding
Folge-Fix zur Domain-Initiative A→C→B (B = #185). Teilprojekt A's Boot-Seeding (
domainBoot.runDomainSeedAndVerify) nahm die last-two-labels-Basis aller Route-Domains, auch nicht-öffentlicher (gc.internal,foo.lan, …). Diese sind über öffentliches DNS nie verifizierbar → blieben dauerhaftpendingund erschienen seit B sichtbar als „unbestätigt" auf der Domains-Seite (reines Rauschen, kein Funktionsfehler).Änderung (
src/services/domainBoot.js)extractBaseDomains(...).filter(isPublicDomain)— nicht-öffentliche Basen werden gar nicht erst angelegt.pending-Zeilen mit nicht-öffentlicher TLD werden entfernt. Verifizierte Zeilen bleiben unberührt (Cleanup trifft nurstatus='pending').Sicherheit
domains-Tabelle per FK; Routen lesenroutes.domaindirekt. Das Löschen von pending-Rauschzeilen hat keine funktionale Auswirkung (sie sind nie inbaseDomains()/isVerified()).Tests
tests/domain_boot_seed.test.jserweitert: interne-TLD-Route wird nicht geseedet, lingerndeold.lan-pending-Zeile wird gepruned, verifiziertekept.internal-Zeile überlebt. RED→GREEN.🤖 Generated with Claude Code
https://claude.ai/code/session_01Nfanfu8v8xvSMCbuAmd8Sq