feat(peers): Geräte-Besitzer-Zuordnung (TP1 — peers.user_id + Admin-UI) - #189
Merged
Merged
Conversation
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teilprojekt 1 — Geräte-Besitzer-Zuordnung
Fundament der Initiative „Pi-hole im Portal": Geräte (Peers) können optional einem Besitzer (bestehendes
users-Konto) zugeordnet werden. Reines Daten- + Admin-UI-Fundament — keine Portal-Optik,portalIdentityunangetastet.Was drin ist
peers.user_id+ Indexidx_peers_user_id(ohne inline-FK — SQLite ignoriert REFERENCES bei ADD COLUMN; FK-Semantik im Service-Layer).peers.createschreibt+returntuser_id;peers.updatesetzt/löscht (undefined=unverändert,null=löschen,<n>=setzen).users.removelöst Besitz transaktional (UPDATE peers SET user_id=NULLvorDELETE) — Gerät überlebt besitzerlos.POST/PUT /api/v1/peersakzeptieren+validierenuser_id(ungültig → 400);GETliefertuser_id+owner_name(einmaliger Prefetch, kein N+1).POST /api/v1/peers/batch-owner— kollisionsfrei VOR/:idregistriert, erbt Admin-Auth+CSRF, Limit ≤ 500.<select>in Add/Edit-Peer-Partials + Bulk-Zuweisung in der bestehenden Batch-Bar.Sicherheit / Scope
user_id/owner_namenur im Admin-Pfad — verhaltensbasierter Leak-Regressionstest (/api/v1/portal/device-Roundtrip + Quell-Scan über alleclient/*-Routen +portal.js).src/middleware/portalIdentity.jsnachweislich unverändert (Scope-Zusicherung). Keinreq.portalOwnerId-Seam, keine Aggregations-Helfer, kein Pi-hole-Widget — alles TP2.Tests
tests/peer_owner_*.test.js).portal_identity*+peers*+users*= 32 grün; i18n-Parität 2 grün.Schnittstelle zu TP2
Die persistierte
peers.user_id-Spalte ist die einzige TP1→TP2-Schnittstelle.Prozess
Subagent-driven (8 Tasks, TDD, zweistufiges Review je Task) + finales opus-Whole-Branch-Review: „Ready to merge".
🤖 Generated with Claude Code