fix(users): Aurora add/edit user modals never opened (overlay shown with display:flex) - #190
Merged
Merged
Conversation
Root cause: aurora.css base `.modal-overlay{display:none}` is loaded after
pro.css (same specificity → wins). The shared users.js opened the user/token
modal overlays with `style.display = ''`, which clears the inline 'display:none'
and falls back to that CSS rule → still none, so the modals stayed invisible
in the Aurora theme (handlers fired, nothing showed). default/pro have base
`display:flex`, so '' worked there.
Fix: open the overlays with explicit `style.display = 'flex'` (inline beats the
class rule in every theme), matching routes.js's working pattern. Hide path
('none') is unchanged. Regression tests assert both overlays open with 'flex'
and document aurora.css's display:none base.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Aurora — Add-User- und Edit-User-Modal öffneten nicht
Symptom: Im Aurora-Theme reagierten auf
/usersdie Buttons „Benutzer hinzufügen" und „Bearbeiten" nicht sichtbar — das Modal erschien nie (default/pro funktionierten).Root Cause
aurora.cssdefiniert die Basis.modal-overlay { display: none }(Z.363) und zeigt das Overlay nur über die.open-Klasse. aurora.css wird nach pro.css geladen (gleiche Spezifität → gewinnt). Die geteiltepublic/js/users.jsöffnete das User-/Token-Modal-Overlay aber mitstyle.display = ''— das löscht nur das inlinedisplay:noneund fällt dann auf die CSS-Regel zurück → in Auroradisplay:none→ Modal bleibt unsichtbar (Handler feuern, nichts erscheint). In default (app.css) und pro (pro.css) ist die Basisdisplay:flex, daher wirkte''dort.Fix
Overlays mit explizitem
style.display = 'flex'öffnen (inline schlägt jede Klassenregel in allen Themes) — exakt das bewährte Muster ausroutes.js(Z.844/1446). Der Hide-Pfad ('none') bleibt unverändert. Betrifft User-Modal (Add+Edit teilen dasselbe Overlay) und das Token-Wizard-Modal (gleicher latenter Bug).Tests (kein jsdom → Source-Invariante, Projektmuster)
Neue Regressionstests in
aurora_theme.test.js: beide Overlays werden mitdisplay:flexgeöffnet (nicht''), plus dokumentierender Test, dass aurora.css.modal-overlayper Default versteckt. RED→GREEN. Lokal: aurora_theme + users = 165/165 grün. Scan bestätigt: kein anderes Seiten-JS hatte dasselbe''-Overlay-Muster.🤖 Generated with Claude Code
https://claude.ai/code/session_01Nfanfu8v8xvSMCbuAmd8Sq