Skoda Connect TP1: protocol core, sync, admin - #222
Merged
Conversation
…btn-sm, drop dead import
CodeQL js/polynomial-redos flagged /.+@.+/ on the admin-supplied email as a polynomial regular expression on uncontrolled data. Swap for an O(n) indexOf check plus the RFC 5321 254-char cap; behaviour is unchanged for valid input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skoda-Connect-Integration TP1 (Spec: docs/superpowers/specs/2026-07-22-skoda-connect-design.md, lokal):
skodaHttpCookie-Jar + Redirect-Follower,skodaAuth), MySkoda-REST-Client mit State-Normalisierung und SSRF-Allowlist für Renderbilder (skodaClient)index.js+skodaVehiclesDB-Layer)skodaAccounts)skodaOwners)/api/v1/skoda(admin-only, Feature-Flagskoda_integration), Seite/skodain allen 3 Themes, i18n de/en inkl. GC.t-Bridge-Regressionstestscripts/skoda-spike.jsfür den Live-BeweisNach Merge offen (Plan-Meilenstein): Live-Beweis mit echten Skoda-Konten via
/skoda-Admin-Seite; Render-CDN-Host nach Spike ggf. pinnen. Portal-Widget folgt als TP2.🤖 Generated with Claude Code
https://claude.ai/code/session_01NACNfM9Uv6hwZwzXpEkHXQ