Skoda Connect TP3: vehicle control (climate/charging/window/lock) - #226
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| await client.startAc('V', 21.4); | ||
| const c = calls[0]; | ||
| assert.equal(c.method, 'POST'); | ||
| assert.match(c.url, new RegExp(API_BASE.replace(/[.]/g, '\\.') + '/api/v2/air-conditioning/V/start$')); |
…omplete-sanitization)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TP3 der Skoda-Initiative: Steuerbefehle an die Fahrzeuge aus Admin und Portal. Baut auf TP1/TP2 (live).
_get→generisches_request(method,path,body)(401-Refresh/429 an einer Stelle) + 10 Control-Methoden gegen die echten MySkoda-Endpunkte.skodaControl): Command-Whitelist (hasOwnProperty), NaN-safe Arg-Validierung, S-PIN-Gate, Cloud-Lockout-Limiter (5/15 min gegen Konto-Sperre), Ausführung unter der Konto-Lock (kein Session-Refresh-Race mit dem Poller), kommando-getriggerter 30-s-Refresh (eigene Cooldown-Map).POST /vehicles/:id/command+PUT /accounts/:id/spin. Portal-APIPOST /skoda/vehicles/:id/command— nur bei echtem Login (req.portalLoggedIn) + owner-gegatet (isOwner(session.userId), nie Trust);login_required=200+reason wie Midea; kein CSRF-Token (Portal-Router, bewusst).Sicherheit
Whitelist dicht, Args NaN-safe, S-PIN nie geleakt (Test), Lockout zählt einmal vor Cloud, Command serialisiert unter Account-Lock, Portal login+owner ohne Trust, XSS: alle PT-Labels + v.id via escHtml. 41 neue/erweiterte Tests, volle Suite 2253/0.
Nach Merge (Pflicht vor „fertig")
Direkt nach Deploy: harmloser Live-Spike (
ac_tempauf die aktuelle Zieltemp = No-Op) gegen das echte Konto zur Bestätigung von Pfad/Body/Statuscode, danach einlockzurcurrentSpin-Verifikation — die 10 Endpunkte stammen aus der myskoda-Referenz und sind erst dann live bewiesen.🤖 Generated with Claude Code
https://claude.ai/code/session_01NACNfM9Uv6hwZwzXpEkHXQ