Skip to content

Remote cleanup failures are accepted as successful shutdown and generation settlement #549

Description

@Calmingstorm

Severity: P2

Verified at v4.10.0, 55c15761845b00931ab2ea4aa184a7797dfd0614.

Locations

src/tools/process_manager.py:2351-2377,2508-2519,2544-2550,2584-2585; embedded controller:250-251

Failure scenario and affected installations

Remote job cleanup failure or already-exited response with unverified group. Shutdown increments killed despite failure string and skips process=None finalproof; generation accepts alreadyexited while failed followup poll ignored.

Verification

Independently traced discarded result/status and final skip. Reviewer mocked shutdown returned1 with jobrunning; alreadyexited+unknownpoll yielded terminate_generationtrue/statusrunning.

Correction and regression coverage

Consume structured proven cleanup verdicts for all remote paths, propagate unknown and do not count refusal/failure as killed. Not changing settled shutdown order.

Duplicate screening

Checked open/closed inventory and GitHub title/body search; no matching root. Harmless mocked operations/temporary data and complete source traces; no live processes killed, remote calls or service actions.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions