Repository navigation
Generic tool exceptions and inner timeouts erase outcome uncertainty after dispatch #603
Description
Severity: P1
Verified at v4.10.0, 55c15761845b00931ab2ea4aa184a7797dfd0614.
Locations
src/tools/executor.py:935-936,1095-1103; src/tools/ssh.py:263-277; src/discord/tool_loop.py:2931-2950,2983-2990; src/turn_state/durability.py:351-360
Failure scenario / benefit and affected installs
Effect-capablehandlerdoesworkthentransport/decoding/cleanupfails, orinnerlocaltimeout. OrdinaryfailedtupleuncertainfalsebecomesDEFINITELY_FAILED withoutabsenceproof.
Verification
Independently traced typedtimeoutonlyunknownrecognition andtuplefailureledger. Reviewer mockedposteffectexception/innerlocaltimeout confirmedfalseunknown, noprocessran.
Correction and tests
Preservecode-owneddispatch/outcomeprovenance forambiguousfailure, notdefinitefailure bydefault.
Duplicate screening
Checked original open/closed inventory and fresh GitHub title/body search. No matching root. Full-path traces and harmless mocks only; mutation strings were never executed.
Activity
Calmingstorm commentedon Sep 30, 2026
Validated as fixed on
campaign/v4.10.0-review(PR #629) at3047c46c: the fix was reviewed against the final code, and its regression tests pass on the branch and in CI. Round-1 correction3cb69a64: a successful internal SSH or executor recovery retry now settles as success (ok=True) while keepinguncertain_outcomeas the possible-duplicate record, so it no longer invites another retry; exhausted or failed retries stay failures. It is not merged to master yet. Closing per the maintainer's instruction; reopen if a later change regresses it.