Name launched nodes from the config entry's name field - #173
Merged
Conversation
Component nodes were always named obelisk_{type}_{index}, so a stack with
several control entries shows up as obelisk_control_0..N on the graph.
The config entries already carry a `name:` key (the include keyed-merge
identity); use it to name the ROS node too: obelisk_{type}_{name}, e.g.
obelisk_control_graph_planner. Entries without a real name (including the
reserved UNKNOWN<n> placeholder for anonymous entries) keep the positional
fallback, so existing unnamed configs are unaffected.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Component nodes were always named obelisk_{type}{index}, so a stack with several control entries shows up as obelisk_control_0..N on the graph. The config entries already carry a
name:key (the include keyed-merge identity); use it to name the ROS node too: obelisk{type}_{name}, e.g. obelisk_control_graph_planner. Entries without a real name (including the reserved UNKNOWN placeholder for anonymous entries) keep the positional fallback, so existing unnamed configs are unaffected.