FIREFLY-1791: Fix username display issue#1837
Merged
Conversation
loitly
force-pushed
the
FIREFLY-1791-erroneous-username
branch
3 times, most recently
from
4872531 to
4dacfc3
Compare
- Refactor RequestOwner to minimize stale user info - Notify client on changes and add client-side logging for debugging - Refactor HttpServiceInput/HttpServices to always include credentials where needed - Add credential caching to JOSSOAdapter to reduce calls to JOSSO identity service - Remove deprecated methods from Logger - Do not publish SELF events
loitly
force-pushed
the
FIREFLY-1791-erroneous-username
branch
from
4dacfc3 to
5cf13f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-1791
Additional changes:
https://github.com/IPAC-SW/irsa-ife/pull/437
lsst/suit#73
The changes ensure more reliable handling of user identity and reduce unnecessary service calls.
FYI: Most of the file changes are due to the HttpServices refactor, so the actual scope of changes is smaller than it appears.
Changes
Testing:
Firefly: https://fireflydev.ipac.caltech.edu/firefly-1791-erroneous-username/firefly/
Expected: No visual changes. Perform a regression test to confirm normal behavior.
SPHEREx: https://firefly-1791-erroneous-username.irsakudev.ipac.caltech.edu/applications/spherex/
firefly.debugTags = 'AppData'Guest.