Conversation
- gradle tweak
robyww
left a comment
robyww
left a comment
There was a problem hiding this comment.
The changes look good.
The upgrade did not affect as much as I thought it would except for the import changes.
I don't see any notes about upgrading outside of docker for the developer development environment. I am assuming then it just getting apache-tomcat-11.0.11 3 and replacing the tomcat.
| COPY --from=builder /opt/work/${build_dir}/build/dist/*.war ${CATALINA_HOME}/webapps-ref/ | ||
|
|
||
| # Enable GZIP compression in Tomcat's HTTP connector | ||
| RUN sed -i 's/<Connector port="8080" protocol="HTTP\/1.1"/<Connector port="8080" protocol="HTTP\/1.1" compression="on" useSendfile="false" compressibleMimeType="text\/html,text\/plain,text\/css,text\/javascript,application\/javascript,application\/json,application\/xml,text\/xml,application\/x-votable+xml,application\/x-yaml,application\/ld+json,image\/svg+xml,text\/csv,application\/xhtml+xml,application\/rss+xml,application\/atom+xml,application\/x-font-ttf,font\/otf,font\/woff,font\/woff2"/' \ |
There was a problem hiding this comment.
Can you make this a script? it is very hard to understand.
There was a problem hiding this comment.
Also is there any related setup to the local developer environment?
There was a problem hiding this comment.
The changes to developer's setup are here: https://github.com/IPAC-SW/irsa-ife/pull/440/files#diff-865bcc67bc7ab28b0cfc427453a74b51aae44b381a574d6769cf78e1f2cf4c44
I don’t think a script would help, but I can add more comments to explain what it’s doing.
kpuriIpac
left a comment
kpuriIpac
left a comment
There was a problem hiding this comment.
Did some basic testing of all the apps linked here (including Euclid, which I think you also built but just missed the link here). Looks good!
3 participants
Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-1836
Additional changes:
https://github.com/IPAC-SW/irsa-ife/pull/440
lsst/suit#75
Changes:
org.apache.commons:fileuploadfrom v1.2.2 to v2.0AnyFileUploadcode to the new v2.0 libraryMultiPartHandler, which was based on the oldcommons-fileuploadpurgetask now also cleans the Maven cache and repositoriesTest:
Please verify core functionality after the Tomcat upgrade, focusing on file upload and WebSocket (including FireflyClient) features.
https://firefly-1836-tomcat-upgrade.irsakudev.ipac.caltech.edu/irsaviewer/
https://firefly-1836-tomcat-upgrade.irsakudev.ipac.caltech.edu/applications/spherex/
https://firefly-1836-tomcat-upgrade.irsakudev.ipac.caltech.edu/applications/wise/
https://fireflydev.ipac.caltech.edu/firefly-1836-tomcat-upgrade/firefly/
https://firefly-1836-tomcat-upgrade.irsakudev.ipac.caltech.edu/suit/