MT5 fix#208
Merged
Merged
Conversation
valeriaRaffuzzi
approved these changes
Apr 9, 2026
valeriaRaffuzzi
left a comment
valeriaRaffuzzi
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix, looks good!
One thing to note is that the energy boundaries in the collision Operator are independent from those of the nucleardatabase. This is something we might want to unify at some point, if possible. But for now this is ok, since it just replaces a hardcoded parameter by a global variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #207 by putting a floor on the neutron energy sampled from neutronScatter. I also added in two new variables: MINIMUM_ENERGY and MAXIMUM_ENERGY. We don't actually use 1E-11 and 20.0 all that often in the code, but there are a handful of places - maybe we should use them more? There might be some places I have forgotten to include these where they might be relevant, so let me know if you think of any.