Fix rare bug related to TMS#215
Merged
Merged
Conversation
ChasingNeutrons
approved these changes
May 1, 2026
ChasingNeutrons
left a comment
ChasingNeutrons
left a comment
Collaborator
There was a problem hiding this comment.
Looks very good to me. Thank you for finding this sneaky bug which may have been doing some subtle damage!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #214: there was an inconsistency in the energy used to sample a reaction and sample the outgoing state of a particle after scattering when using TMS.
When using TMS, a relative energy is sampled in 'ceNeutronMaterial % sampleNuclide' for each nuclide. That energy is that saved in collDat % E and subsequently used to retrieve all cross sections. However, during scattering, p % E was used to sample the outgoing particle.
This was now fixed in neutronCEstd and neutronCEimp.