src/Graphics/Vulkan/VulkanTexture.cpp:90-94, blit at :423
The gate at :90-94 checks only VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_LINEAR_BIT, but vkCmdBlitImage
(:423) additionally requires VK_FORMAT_FEATURE_BLIT_SRC_BIT / BLIT_DST_BIT. Harmless for the two formats
actually produced today (:79-81), but the check is incomplete and will not catch a future format addition.
The mip math is correct and was verified: mipW > 1 ? mipW/2 : 1 (:417-418, :436-437) never reaches 0, and
the barrier chain (:400-407, :428-434, :441-448) is complete.
Severity: minor.
Found by a full audit of the graphics layer. Assessed severity: minor.
src/Graphics/Vulkan/VulkanTexture.cpp:90-94, blit at:423The gate at :90-94 checks only
VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_LINEAR_BIT, butvkCmdBlitImage(:423) additionally requires
VK_FORMAT_FEATURE_BLIT_SRC_BIT/BLIT_DST_BIT. Harmless for the two formatsactually produced today (:79-81), but the check is incomplete and will not catch a future format addition.
The mip math is correct and was verified:
mipW > 1 ? mipW/2 : 1(:417-418, :436-437) never reaches 0, andthe barrier chain (:400-407, :428-434, :441-448) is complete.
Severity: minor.
Found by a full audit of the graphics layer. Assessed severity: minor.