Skip to content

Smaller DX/Common defects, verified #173

Description

@CanReader
  • Input-layout AddRef leak: src/Graphics/DirectX11/DirectX11Shader.cpp:112.
  • D3D12 debug layer never enabled anywhere, while DX11 does enable its own (DirectX11Renderer.cpp:72)
    which is why DX12 state bugs like Wire shadow filter quality to the quality tiers #35/Point light shadows #36 went undetected. DX12 adapter selection is also dead code.
  • Per-texture shader-visible descriptor heaps are created but never bound (DX12).
  • Trailing pendingState dropped: src/Graphics/Common/RenderCommandQueue.cpp:176: the last queued
    state change never applies.
  • DrawIndexedCommand applies startIndexLocation to the vertex buffer, while baseVertexLocation is
    dead.

Severity: minor individually; the missing DX12 debug layer is the reason the two corruption-class DX12
bugs above survived.

Found by a full audit of the graphics layer. Assessed severity: minor: cluster.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: renderingRenderer, shaders, post processingbackend: dx11Specific to the dx11 backendbackend: dx12Specific to the dx12 backendbugSomething isn't workingpriority: lowNice to have

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions