Conversation
The Tauri deb named the binary after the cargo bin ('app'), but the Flatpak
manifest, command:, .desktop and icons all reference 'canonic'. flatpak-builder
failed: install: cannot stat 'usr/bin/canonic'. Setting mainBinaryName=canonic
makes the bundled binary, .desktop and icons all 'canonic.*', matching the
manifest. Updater asset names are productName-derived, so unchanged.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release run for #85 failed in
build-flatpak(both arches):The Tauri
.debnamed the executable after the Cargo bin (app), but theFlatpak manifest,
command:,.desktopand icon paths all referencecanonic. WithmainBinaryNameunset, Tauri fell back to the crate bin name.Fix
Set
"mainBinaryName": "canonic"intauri.conf.json. The bundled binary,.desktopand icons are nowcanonic.*, satisfying every manifest reference.Updater asset names are productName-derived (
canonic.app.tar.gz,canonic_*_x64-setup.exe,*.AppImage), so they're unchanged andlatest.jsonURLs still resolve.
Verified: built
.debfrom the failed run containsusr/bin/app; manifestexpects
usr/bin/canonic.cargo checkpasses; 279 tests pass.Context
Completes the updater/release fixes whose siblings already merged via #85:
-D warningserrors (FETCH_HEADformat!, redundantu64cast)core:window:allow-set-focuscapability (titlebarsetFocus)verify-manifestpost-release smoke test forlatest.jsonMerging this triggers a clean release that should publish a signed
latest.json.🤖 Generated with Claude Code