Conversation
…us-mode panels Peer sharing: - get_lan_ip now picks the real private-LAN IPv4, skipping VPN/tunnel/AWDL/ bridge/VM interfaces and never falling back to loopback in the share link (a loopback link worked on the host but was unreachable from other machines). Pure selection extracted to choose_lan_ip with unit tests. Window controls: - Keep frameless custom controls (not native decorations), but render them on the side the desktop is configured for via new window_controls_side command (reads GNOME button-layout; Windows/other = right). macOS keeps traffic lights. - Extracted buttons into WindowControls.vue. Focus mode: - Wide-screen titlebar now exposes left/right panel toggles (only way to reach the hidden sidebars in focus mode). - Floating panel rendered with leftExpanded/rightExpanded so tabs/content show expanded instead of the collapsed icon strip. - Small-screen floating modal fills the viewport (specificity fix over compact). - Floating modal repaints to the opaque --bg-surface (joins the floater re-opaque list) so it isn't see-through in window-transparency mode. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes from cross-machine testing of the window-chrome / peer-discovery / focus-mode work (#90).
Peer sharing — share link now reachable from other machines
get_lan_ippicks the real private-LAN IPv4, skipping VPN/tunnel/AWDL/bridge/VM interfaces, and never falls back to loopback in the share link. A loopback link worked on the sharing machine but was unreachable from any peer ("could not reach…"). Pure selection split intochoose_lan_ipwith 4 unit tests.Window controls — frameless, on the system's configured side
window_controls_sidecommand (reads GNOMEbutton-layout; Windows / non-GNOME default to right). macOS keeps native traffic lights.WindowControls.vue.Focus mode
leftExpanded/rightExpanded) instead of the collapsed icon strip with no content.--bg-surface(joins the floater re-opaque list) so it isn't see-through in window-transparency mode.Specs updated in
REQUIREMENTS.md. All 311 tests pass;cargo checkclean. Ran/simplifyover the diff.🤖 Generated with Claude Code