Conversation
…nder Flatpak Share status: - syncActiveShares() was defined but never called, so the Share panel never reflected the backend's real active shares (e.g. an auto-started "share all workspaces"). Now synced on workspace load and on Share-panel mount. Flatpak agents (Linux): - The sandbox can't see host-installed CLIs (claude/gemini/codex), so detection, model listing, and launch all failed. Added in_flatpak() + host_command() and route is_installed, list_models and the pty_spawn exec through `flatpak-spawn --host` when sandboxed (cwd via --directory, env via --env=). - Manifest: add --talk-name=org.freedesktop.Flatpak (the Development portal flatpak-spawn requires). MCP env is forwarded; --share=network already shares the host loopback so the host agent reaches the in-app MCP server. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Finder/Dock launches inherit launchd's minimal PATH
(/usr/bin:/bin:/usr/sbin:/sbin), so `which claude` and bare-binary
spawns missed Homebrew/npm-global installs after the Tauri refactor —
every preset showed "Not installed" and sessions wouldn't start.
- Add cached login_shell_path(): queries `$SHELL -ilc 'printf %s "$PATH"'`,
merges inherited PATH + common fallbacks (homebrew, ~/.local/bin,
~/.cargo/bin, npm-global, bun, deno, volta), deduped.
- host_command() and pty_spawn() (non-Flatpak) set child PATH to it so
detection and launch find host agents. Flatpak path unchanged.
- Fix agent_control_add_custom_agent to return { ok, agent } — the shape
the store and tests expect; bare entry left result.ok undefined so
added agents never rendered.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from 0.2.8/0.2.9 testing (Mac + Linux/Alpine flatpak). Two-way peer discovery is confirmed working; these fix the remaining reported issues.
Share status not shown
syncActiveShares()(sync from the backend's real active-share list) was defined but never called, so the Share panel showed "not sharing" even when a share was active (e.g. auto-started "share all workspaces"). Now synced on workspace load and on Share-panel mount.CLI agents under Flatpak (Linux)
The flatpak sandbox can't see host-installed CLIs (
claude/gemini/codex), so detection, model listing, and launch all failed — which also made the agent list look empty ("can't find / can't add an agent"). Addedin_flatpak()+host_command()and routeis_installed,list_models, and thepty_spawnexec throughflatpak-spawn --hostwhen sandboxed (cwd via--directory, env via--env=). Manifest gains--talk-name=org.freedesktop.Flatpak(the Development portal flatpak-spawn needs). MCP env is forwarded;--share=networkalready shares the host loopback so the host agent reaches the in-app MCP server.Also
Specs updated. 311 tests pass;
cargo checkclean; version synced to 0.2.9. The Flatpak agent path can't be verified locally (no flatpak here) — needs a flatpak rebuild to test.🤖 Generated with Claude Code