Repository navigation
fix(profile): add missing UN member states to the country list - #2393
saisarans2007 wants to merge 1 commit into
Conversation
isValidCountry rejected Antigua and Barbuda, Congo and the Democratic Republic of the Congo, so users from those countries couldn't save their country on the profile.
|
Thank you for submitting your pull request, @saisarans2007! 🙌 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
This pull request has had no activity for 14 days and has been marked as |
|
This pull request has been automatically closed after 21 days of inactivity. Please reopen or raise a fresh PR rebased on the latest main branch if you would like to continue. Thank you! |
Summary
The country allow-list in
backend/utils/nameCountry.jswas missing three UN member states: Antigua and Barbuda, Congo and Democratic Republic of the Congo. The profile update rejected them with "Please enter a valid country name." They're added in alphabetical order. I checked the list against all 193 UN members, and nothing else is missing.Tests
Added
backend/tests/nameCountry.unit.test.js:main.npx vitest run: 23 files, 257 tests passing.Closes #2392
Summary
The author reports that
npx vitest runpassed with 23 files and 257 tests.