Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions backend/controllers/achievementController.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,17 @@ exports.getAchievements = async (req, res) => {
exports.saveAchievements = async (req, res) => {
const { unlockedAchievements } = req.body;

if (!unlockedAchievements || !Array.isArray(unlockedAchievements)) {
if (!unlockedAchievements || !Array.isArray(unlockedAchievements)) {
return res.status(400).json({
success: false,
error: "unlockedAchievements must be a valid array"
});
}

if (unlockedAchievements.length === 0) {
return res.json({ success: true });
}

const unknown = unlockedAchievements.filter((id) => !VALID_ACHIEVEMENTS.has(id));

if (unknown.length > 0) {
Expand All @@ -37,12 +41,15 @@ exports.saveAchievements = async (req, res) => {
}

try {
await User.findByIdAndUpdate(
const user = await User.findByIdAndUpdate(
req.user._id,
{ $addToSet: { unlockedAchievements: { $each: unlockedAchievements } } },
);
if (!user) {
return res.status(404).json({ success: false, error: "User not found" });
}
res.json({ success: true });
} catch (err) {
res.status(500).json({ success: false, error: "A server error occurred" });
}
};
};
22 changes: 22 additions & 0 deletions backend/tests/achievementController.unit.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,28 @@ describe('achievementController', () => {
});
});

it('handles empty unlockedAchievements array as a successful no-op without calling findByIdAndUpdate', async () => {
const req = makeReq({ unlockedAchievements: [] });
const res = makeRes();

await saveAchievements(req, res);

expect(User.findByIdAndUpdate).not.toHaveBeenCalled();
expect(res.json).toHaveBeenCalledWith({ success: true });
});

it('returns 404 if user is not found during save', async () => {
User.findByIdAndUpdate.mockResolvedValue(null);

const req = makeReq({ unlockedAchievements: ['First Interview'] });
const res = makeRes();

await saveAchievements(req, res);

expect(res.status).toHaveBeenCalledWith(404);
expect(res.json).toHaveBeenCalledWith({ success: false, error: 'User not found' });
});

it('successfully saves achievements for a valid request', async () => {
User.findByIdAndUpdate.mockResolvedValue({});

Expand Down
Loading