Repository navigation
docs: improve clarity of cron run report and rate-limit status #2398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hesmitha-07
wants to merge
1
commit into
Canopus-Labs:main
Choose a base branch
from
hesmitha-07:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,65 +1,92 @@ | ||
| # PrepPilot GSSOC Cron Run - 2026-08-12 03:15 UTC | ||
|
|
||
| ## Phase 1 - Triage | ||
| - Found 28+ open PRs from tmdeveloper007 prior to this run | ||
| - Open PRs include various states: unstable (CI pending), dirty (conflicts) | ||
| - No RED_CI or CHANGES_REQUESTED PRs requiring immediate fix cycles | ||
| - Phase 1: no triage intervention needed | ||
|
|
||
| ## Phase 2 - New PRs Shipped | ||
|
|
||
| | PR # | Title | Issue | Status | | ||
| |------|-------|-------|--------| | ||
| | #1853 | fix : bound job cache keys with normalized role and country | #1848 | AUTO-CLOSED (rate-limited) | | ||
| | #1854 | fix : added max length guards on flashcard category and sourceId fields | #1849 | AUTO-CLOSED (rate-limited) | | ||
| | #1855 | fix : added max length guards on session role and company fields | #1850 | AUTO-CLOSED (rate-limited) | | ||
| | #1856 | fix : added max length guards on notes summary URL fields | #1851 | AUTO-CLOSED (rate-limited) | | ||
| | #1857 | test : added unit tests for problemSolverParser utility | #1852 | AUTO-CLOSED (rate-limited) | | ||
| ## Phase 1 - Pull Request Triage | ||
|
|
||
| - The run report recorded more than 28 existing open pull requests before triage. | ||
| - Existing pull requests had different states, including pending CI checks and merge conflicts. | ||
| - No pull requests requiring immediate intervention were identified in the reported triage. | ||
| - No triage changes were recorded during this phase. | ||
|
|
||
| ## Phase 2 - Pull Requests Created | ||
|
|
||
| The following pull requests were created during this run. All five were subsequently closed by the repository's contribution rate-limit workflow. | ||
|
|
||
| | PR | Description | Related Issue | Outcome | | ||
| |---|---|---|---| | ||
| | #1853 | Bound job cache keys using normalized role and country | #1848 | Closed by rate-limit workflow | | ||
| | #1854 | Add maximum-length validation for flashcard category and sourceId | #1849 | Closed by rate-limit workflow | | ||
| | #1855 | Add maximum-length validation for session role and company | #1850 | Closed by rate-limit workflow | | ||
| | #1856 | Add maximum-length validation for notes summary URL fields | #1851 | Closed by rate-limit workflow | | ||
| | #1857 | Add unit tests for problemSolverParser | #1852 | Closed by rate-limit workflow | | ||
|
|
||
| ## Rate Limit Status | ||
| - The maintainers' `.github/workflows/rate-limit-contributions.yml` enforces MAX_OPEN_PRS=3 | ||
| - tmdeveloper007 currently has 33 open PRs (far exceeding the limit of 3) | ||
| - All 5 newly created PRs were auto-closed by the rate-limit workflow | ||
| - No collaborator bypass available for tmdeveloper007 | ||
|
|
||
| ## PR Details (were created, now closed) | ||
|
|
||
| ### PR #1853 - job cache key bounding (AUTO-CLOSED) | ||
| - **File**: `backend/controllers/jobController.js` | ||
| - **Fix**: Apply `normalizeRole()` and `normalizeCountry()` to incoming request params before building cache key | ||
| - **Tests**: Would fix 4 failing tests in `jobCache.boundedKeys.unit.test.js` | ||
| - **Status**: All 127 backend tests pass on `#1848` branch | ||
|
|
||
| ### PR #1854 - flashcard max length guards (AUTO-CLOSED) | ||
| - **File**: `backend/Input_validators/ValidateFlashcard.js` | ||
| - **Fix**: Add `.max(100)` to `category`, `.max(128)` to `sourceId` | ||
| - **Status**: All 127 backend tests pass | ||
|
|
||
| ### PR #1855 - session max length guards (AUTO-CLOSED) | ||
| - **File**: `backend/Input_validators/ValidateSession.js` | ||
| - **Fix**: Add `.max(120)` to `role` and `company` | ||
| - **Status**: All 127 backend tests pass | ||
|
|
||
| ### PR #1856 - notes summary URL max length guards (AUTO-CLOSED) | ||
| - **File**: `backend/Input_validators/ValidateNotesSummary.js` | ||
| - **Fix**: Add `.max(2048)` to `url` and `sourceUrl` | ||
| - **Status**: All 127 backend tests pass | ||
|
|
||
| ### PR #1857 - problemSolverParser unit tests (AUTO-CLOSED) | ||
| - **File**: `backend/tests/problemSolverParser.unit.test.js` (new) | ||
| - **Fix**: 27 unit tests covering `buildSolverPrompt`, `extractSection`, `parseSolverOutput` | ||
| - **Status**: All 27 new tests pass | ||
|
|
||
| ## Issues Created | ||
| - #1848: fix : bound job cache keys with normalized role and country | ||
| - #1849: fix : add max length guards on flashcard category and sourceId fields | ||
| - #1850: fix : add max length guards on session role and company fields | ||
| - #1851: fix : add max length guards on notes summary URL fields | ||
| - #1852: test : add unit tests for problemSolverParser utility | ||
|
|
||
| ## Notes | ||
| - No emojis used per project rules | ||
| - All PRs use --force-with-lease for any subsequent updates | ||
| - No `.github/workflows/`, `package.json`, `package-lock.json`, or `requirements.txt` modified | ||
| - Token used: vault `${GH_TOKEN}` format | ||
| - **CRITICAL**: The rate limit of MAX_OPEN_PRS=3 makes it impossible to submit new PRs while 33 are open. Recommend: (1) close existing reviewed/rejected PRs, or (2) add tmdeveloper007 to EXCLUDED_USERS in rate-limit workflow | ||
|
|
||
| - The repository's rate-limit workflow configures a maximum of three open pull requests per contributor. | ||
| - The original run report recorded 33 open pull requests for the contributor at the time of its rate-limit assessment. | ||
| - All five pull requests created during the run were automatically closed by the rate-limit workflow. | ||
| - The report did not record a collaborator bypass for the affected contributor. | ||
| - Contributors should resolve or close existing pull requests before opening additional ones, in accordance with repository policy. | ||
|
|
||
| ## Pull Request Details | ||
|
|
||
| ### PR #1853 - Bound Job Cache Keys | ||
|
|
||
| **File:** `backend/controllers/jobController.js` | ||
|
|
||
| **Change:** Normalize incoming role and country parameters before constructing cache keys. | ||
|
|
||
| **Reported validation:** The original report states that 127 backend tests passed on the associated branch. | ||
|
|
||
| ### PR #1854 - Validate Flashcard Field Lengths | ||
|
|
||
| **File:** `backend/Input_validators/ValidateFlashcard.js` | ||
|
|
||
| **Change:** Add maximum-length validation for `category` and `sourceId`. | ||
|
|
||
| **Reported validation:** The original report states that 127 backend tests passed. | ||
|
|
||
| ### PR #1855 - Validate Session Field Lengths | ||
|
|
||
| **File:** `backend/Input_validators/ValidateSession.js` | ||
|
|
||
| **Change:** Add maximum-length validation for the `role` and `company` fields. | ||
|
|
||
| **Reported validation:** The original report states that 127 backend tests passed. | ||
|
|
||
| ### PR #1856 - Validate Notes Summary URL Lengths | ||
|
|
||
| **File:** `backend/Input_validators/ValidateNotesSummary.js` | ||
|
|
||
| **Change:** Add maximum-length validation for `url` and `sourceUrl`. | ||
|
|
||
| **Reported validation:** The original report states that 127 backend tests passed. | ||
|
|
||
| ### PR #1857 - Add Problem Solver Parser Tests | ||
|
|
||
| **File:** `backend/tests/problemSolverParser.unit.test.js` | ||
|
|
||
| **Change:** Add unit tests for `buildSolverPrompt`, `extractSection`, and `parseSolverOutput`. | ||
|
|
||
| **Reported validation:** The original report states that all 27 new unit tests passed. | ||
|
|
||
| ## Related Issues | ||
|
|
||
| - #1848: Bound job cache keys using normalized role and country. | ||
| - #1849: Add maximum-length validation for flashcard category and sourceId. | ||
| - #1850: Add maximum-length validation for session role and company. | ||
| - #1851: Add maximum-length validation for notes summary URL fields. | ||
| - #1852: Add unit tests for problemSolverParser. | ||
|
|
||
| ## Verification Notes | ||
|
|
||
| - The test results above are transcribed from the original run report and have not been independently rerun as part of this documentation change. | ||
| - Pull request closure due to rate limiting does not, by itself, indicate that the code changes or tests failed. | ||
| - Recheck the current pull request states and CI results before attempting to resubmit any changes. | ||
| - No changes to application code, dependency manifests, or workflow configuration are included in this documentation-only correction. | ||
|
|
||
| ## Follow-up Recommendations | ||
|
|
||
| 1. Review the rate-limit workflow and follow the repository's contribution policy. | ||
| 2. Verify the current status of related issues and pull requests before creating new submissions. | ||
| 3. Rerun relevant tests when preparing any code changes for resubmission. | ||
| 4. Update this report with verified outcomes if further triage or testing occurs. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scope the three-PR limit to non-exempt contributors.
The workflow exempts excluded users and collaborators with sufficient permissions, while separately force-limiting selected users. This wording presents three open pull requests as a universal limit. State that the limit applies to contributors subject to rate limiting, or document the workflow exceptions. Line 27 only describes this report's recorded outcome for one contributor. (github.com)
Proposed wording