Repository navigation
Fix Achievement Validation and Improve Input Handling #2400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hemamanju173-svg
wants to merge
1
commit into
Canopus-Labs:main
Choose a base branch
from
hemamanju173-svg:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: Canopus-Labs/PrepPilot
Length of output: 21494
Use
isValidAchievementinsaveAchievements, and persist trimmed titles.saveAchievementschecks each raw value withVALID_ACHIEVEMENTS.has(id). A title such as" First Interview "fails this check and returns 400.isValidAchievementaccepts the same title because it trims the value. Switch the check to the helper. Persist the trimmed values as well. Otherwise, a padded title that passes validation can be stored next to its trimmed form and create a duplicate entry through$addToSet.Suggested fix
In
backend/controllers/achievementController.js:Add the normalized list after the early-return block, before
try {. Every entry is a string at this point, because non-strings failisValidAchievement: