This repository was archived by the owner on Jun 11, 2025. It is now read-only.
Add CMake support#5
Open
JohelEGP wants to merge 1 commit intoCaptainCrowbar:masterfrom
JohelEGP:cmake
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings.
I made this because I need to use this library, and CMake is the easiest way for me to consume it. I hope this is well-received.
A few notes:
cxx_std_17. The library's introduction says it uses "idiomatic C++11/14," but I quickly met build errors because it usesstd::string_view.pcre2-8. One of the manyFindPCRE.cmakein the web could be used instead for better portability, minding their copyright and licenses of accompanying projects.unit-test.cppwhen adding new tests.