fix: implement email channel, satellite ingestion, credit ID validation, monotonic timestamps#367
Merged
Oluwaseyi89 merged 6 commits intoMay 30, 2026
Conversation
, CarbonScribe#318 CarbonScribe#318 - Implement email notification channel (Go) - Replace //go:build future stub with production EmailChannel - SMTP/AWS SES support via environment variables - Input validation (address format, required fields) - Exponential-backoff retry logic (3 attempts) CarbonScribe#316 - Implement satellite data ingestion pipeline (Go) - ingestion/satellite.go: SatellitePipeline with validation (source allowlist, data-type constraints, future-date guard) - models.go: SatelliteReading, BoundingBox, IngestSatelliteRequest - repository.go: Repository interface - service.go: Service orchestrating pipeline + list - handler.go: POST /satellite and GET /:projectID Gin endpoints - postgres_repository.go: PostgresRepository (Save + ListByProject) CarbonScribe#314 - Validate registry_credit_id in merkle_bridge (Rust) - Add errors CreditIdTooShort(13), CreditIdTooLong(14), CreditIdInvalidCharset(15) - validate_registry_credit_id(): 8-64 chars, [A-Za-z0-9_-] only - Called in mint_wrapped and mark_retired - Tests: too-short, too-long, bad-charset, valid ID, mark_retired CarbonScribe#313 - Add monotonic timestamp enforcement in registry_contract (Rust) - Add Error::TimestampNotMonotonic(9) - StorageKey::MonotonicEnforcement and LastTimestamp(String) - set_monotonic_enforcement(enabled) admin entry point - is_monotonic_enforcement_enabled() view function - Checks in anchor_document and anchor_document_batch - Tests: toggle, allow increasing, reject same/earlier timestamps, disabled allows any order Closes CarbonScribe#313, CarbonScribe#314, CarbonScribe#316, CarbonScribe#318
|
@BashMan11 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This was referenced May 29, 2026
Contributor
|
@BashMan11 you have done a good job! But there are pending test failures to fix. Try fixing them. |
…ppy warnings - Updated all test registry_credit_id values to meet the minimum 8-character requirement, fixing test failures due to CreditIdTooShort errors. - Refactored needless range loops to use iterators as recommended by clippy. - Ensured all tests pass and contract enforces correct ID validation.
…lient - Ensure correct import and usage of stellar.MethodologyClient interface - Fix type and method signature mismatches in methodology-validator and handler - Guarantee compatibility with GetMethodologyMeta and IsValidMethodology implementations - Clean up package naming and interface usage for validation logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves four assigned issues in a single commit.
#318 — Email notification channel (Go)
//go:build futurestub with productionEmailChannelEMAIL_SMTP_HOST,EMAIL_SMTP_USER, etc.)#316 — Satellite data ingestion pipeline (Go)
ingestion/satellite.go:SatellitePipelinewith source allowlist, data-type constraints, future-date guardmodels.go:SatelliteReading,BoundingBox,IngestSatelliteRequestrepository.go:Repositoryinterfaceservice.go:Serviceorchestrating pipeline + listhandler.go:POST /api/v1/monitoring/satelliteandGET /api/v1/monitoring/:projectIDpostgres_repository.go:PostgresRepository(Save + ListByProject)#314 — Validate
registry_credit_idinmerkle_bridge(Rust)CreditIdTooShort(13),CreditIdTooLong(14),CreditIdInvalidCharset(15)validate_registry_credit_id(): 8–64 chars,[A-Za-z0-9_-]onlymint_wrappedandmark_retired#313 — Monotonic timestamp enforcement in
registry_contract(Rust)TimestampNotMonotonic(9)MonotonicEnforcement,LastTimestamp(String)set_monotonic_enforcement(enabled)— admin-only toggleis_monotonic_enforcement_enabled()— view functionanchor_documentandanchor_document_batchTesting
go test ./internal/notifications/... ./internal/monitoring/...— all passCloses #313
Closes #314
Closes #316
Closes #318