fix(lora): make async init recoverable and thread-safe - #152
Merged
dianjixz merged 1 commit intoAug 20, 2026
Merged
Conversation
The async-init rework used a detached thread plus a one-shot, no-retry path. A transient cold-boot / EXT5V failure would wedge the page as "LoRa unavailable" with no recovery, and re-entering the page could run two init threads against the global backend state at once. - Keep the init thread joinable and join it in the destructor and before each new attempt, so the global hardware state is never touched by two init threads concurrently. - Retry failed initialization with a 3s backoff instead of giving up. - Split the misleading "LoRa is still initializing" send status into a distinct "LoRa unavailable" message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The async-init rework used a detached thread plus a one-shot, no-retry path. A transient cold-boot / EXT5V failure would wedge the page as "LoRa unavailable" with no recovery, and re-entering the page could run two init threads against the global backend state at once.