Skip to content

Fix referral closing timeline#1123

Open
Rabi94 wants to merge 4 commits into
mainfrom
referral-timeline-midnight
Open

Fix referral closing timeline#1123
Rabi94 wants to merge 4 commits into
mainfrom
referral-timeline-midnight

Conversation

@Rabi94
Copy link
Copy Markdown
Collaborator

@Rabi94 Rabi94 commented May 21, 2026

Set today’s referral close time to the current time while keeping past close dates at 12:00 AM.
Screenshot (1032)
Use MUI DateTimePicker for referral close dates so today defaults to the current time and past dates default to 12:00 AM unless the user changes the time.
Screenshot (1035)

@Rabi94 Rabi94 requested a review from PabloDinella as a code owner May 21, 2026 21:49
@Rabi94 Rabi94 linked an issue May 21, 2026 that may be closed by this pull request
@LarsKemmann
Copy link
Copy Markdown
Member

Oh, I see the issue here. Thank you for doing this work, but I now realize that this is the wrong approach. We don't actually want users to have to put in the time of day here. I think that the correct fix would be to show only the date on the timeline, for all entries where we don't actually get a specific time. The only time that we want a time component is with a child location change. Every other requirement, note, etc. should not have that in the input field or in the timeline display.

I had been thinking about the timestamp on the timeline from the perspective of an audit log showing the exact time when a user put something into the system. I think that's confusing the issue, using the same date/time field on the timeline to mean two different things, so that was my mistake. At some point, we can create an audit log view or something like that, but for now, we should really keep that timeline simple and date-focused. And an audit log wouldn't allow customizing the timestamp anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Referral closing timeline entries always show midnight

2 participants