forked from docusealco/docuseal
-
Notifications
You must be signed in to change notification settings - Fork 0
CP-10379 ordered signing #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f186498
add named signing order values and defer to template signing order
ryanarakawa 4a24f4e
enforce new signing order logic
ryanarakawa 8cea501
wire up named signing order through controllers
ryanarakawa 882d7dd
add signing order UI
ryanarakawa 19abefb
add template.preferences_updated webhook job
ryanarakawa f21c8d3
add template.preferences_updated webhook support
ryanarakawa d09bb55
rubocop and rspec fixes
ryanarakawa eb4e6da
erb_lint violation fixes
ryanarakawa eed6b7f
harden webhooks with account_id and partnership_id in payload
ryanarakawa 3a3de4d
use external account id to match correctly in webhook payload
ryanarakawa 1f5af49
PR comments
ryanarakawa b03a9eb
update to non-predicate method for rubocop
ryanarakawa ba64767
erb_lint formatting fix
ryanarakawa c411f87
PR comment changes
ryanarakawa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| module TemplateWebhooks | ||
| def enqueue_template_created_webhooks(template) | ||
| WebhookUrls.for_template(template, 'template.created').each do |webhook_url| | ||
| SendTemplateCreatedWebhookRequestJob.perform_async('template_id' => template.id, | ||
| 'webhook_url_id' => webhook_url.id) | ||
| end | ||
| end | ||
|
|
||
| def enqueue_template_updated_webhooks(template) | ||
| WebhookUrls.for_template(template, 'template.updated').each do |webhook_url| | ||
| SendTemplateUpdatedWebhookRequestJob.perform_async('template_id' => template.id, | ||
| 'webhook_url_id' => webhook_url.id) | ||
| end | ||
| end | ||
|
|
||
| def enqueue_template_preferences_updated_webhooks(template) | ||
| WebhookUrls.for_template(template, 'template.preferences_updated').each do |webhook_url| | ||
| SendTemplatePreferencesUpdatedWebhookRequestJob.perform_async('template_id' => template.id, | ||
| 'webhook_url_id' => webhook_url.id) | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should maybe add a comment explaining why we're skipping these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment there, it's because of the
IframeAuthenticationconcern, they used to use Devise, but we don't need that since we don't have them log into Docuseal.