This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Routing result simplification#391
Open
farfromrefug wants to merge 5 commits intoCartoDB:masterfrom
Open
Conversation
Contributor
|
I could be wrong but I think the 'pointIndex' calculation is correct only if there is a single leg in the result. A simple check like below should remove redundant points and work in case of multiple legs also: |
Contributor
Author
|
@mtehver yes you are right i suppoed there aws only one leg! Do you know in which case we have multiple leg so i could try? |
Contributor
Author
|
@mtehver i finally took a look at that and i tired what you suggest and it did not work. Not sure exactly why but i still had all the points. |
…sult_simplification # Conflicts: # all/native/routing/utils/ValhallaRoutingProxy.cpp
…le-sdk # Conflicts: # all/native/routing/utils/ValhallaRoutingProxy.cpp # Conflicts: # all/native/routing/utils/ValhallaRoutingProxy.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the points for the RoutingResult.
Before we were creating the points based on the manoeuvres. However this was adding unwanted duplicate points(multiple manoeuvres at the same point?).
On an example route (computed with android dev here):
Now with that PR it returns the shape returned from valhalla. And the instruction indexes are still correct.