Corrects CORS setup to allow login cookie to be set#11
Open
StuTheWebGuy wants to merge 75 commits into
Open
Conversation
…notnull to user_id in categories
# Conflicts: # api/config/web.php # api/controllers/BoxesController.php # api/controllers/CategoriesController.php # api/controllers/PokemonSpeciesController.php # api/controllers/SiteController.php # api/controllers/TeamsController.php # api/models/Category.php # api/rest/ActiveController.php # api/rest/Controller.php
added 'loginUrl' => null to web.php
todo: add to .env
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PHPSESSIDcookie on login wasn't being set, in part because the CORS setup was incorrect. This PR amends the CORS config on the API to fix this.The other fix that needs doing (outside the scope of this PR) is to ensure all
fetch()calls in the frontend use a base URL that matches the CORS origin, and that the fetch options includecredentials: 'include'.