Skip to content

Conversation

@Sallie00
Copy link
Contributor

@Sallie00 Sallie00 commented Nov 5, 2025

Summary

This PR improves our end‐to‐end testing performance and maintainability.
I consolidated redundant UI assertions, optimized setup steps, and streamlined the GitHub Actions workflow to reduce execution time and improve stability.

Changes

  • Merged 49 tests → 29 tests (removed duplicates and grouped related checks)
  • Updated GitHub Actions workflow: replaced pipenv run playwright install --with-deps with pipenv run playwright install chromium

@coderabbitai
Copy link

coderabbitai bot commented Nov 5, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Sallie00
Copy link
Contributor Author

Sallie00 commented Nov 5, 2025

Hi, @FedericoTartarini
I’ve already optimized the test code by merging redundant checks, reducing repetitive assertions, and improving setup consistency.
In the GitHub Actions workflow, I’ve also replaced pipenv run playwright install --with-deps with pipenv run playwright install chromium to shorten installation time.
I did experiment with pytest-xdist to parallelize the tests (pytest -n auto), but unfortunately it caused instability – likely because multiple browser instances were trying to launch concurrently, and some tests rely on shared resources (e.g. temporary files or global settings).

@Sallie00 Sallie00 marked this pull request as ready for review November 5, 2025 00:18
@FedericoTartarini FedericoTartarini merged commit f9465e6 into CenterForTheBuiltEnvironment:development Nov 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants