Ship staged skill release - #11
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3bcb6a6e1b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if environment_is_current( | ||
| python_exe, | ||
| python_version=python_version, | ||
| requirements_sha256=digest, | ||
| ): | ||
| return |
There was a problem hiding this comment.
When an installed environment still has its marker and interpreter but a package has been removed, corrupted, or otherwise made unimportable, this early return treats it as current. The following runtime-validation step then fails, and every subsequent deployment repeats the same skip/fail cycle because the marker remains unchanged. Verify package readiness before returning or make validation failure invalidate and rebuild the environment so deployment can repair drift.
Useful? React with 👍 / 👎.
| snapshot = model_snapshot(cache, model_id, revision) | ||
| if not snapshot.is_dir(): | ||
| raise ValidationError(f"missing model snapshot: {snapshot}") |
There was a problem hiding this comment.
If a pinned snapshot directory exists but is incomplete or corrupted—for example after cache damage or deletion of a config or weight file—this check accepts it and runtime-validation.py ultimately prints OK. Regular text selection then fails later in mask_worker.py when from_pretrained(..., local_files_only=True) accesses the missing files. Validate the required snapshot artifacts, rather than directory existence alone, before declaring the runtime ready.
Useful? React with 👍 / 👎.
1 participant
Staged skill lifecycle release branch.