fix(auth): save user name on Google sign-in#98
Merged
Conversation
Google's oauth2/v2/userinfo returns given_name / family_name when the profile scope is granted, but google_callback only read id and email, so a Google sign-up never stored a name. Extract given_name/family_name in the callback and pass them to _find_or_create_user, which writes them to profiles.first_name / profiles.last_name (the existing Phase 10.18 name columns; no migration needed). The profiles upsert uses COALESCE(profiles.<col>, EXCLUDED.<col>) so the name is only set when currently empty: a name the user later edits is never overwritten by a subsequent Google login. Empty incoming values are normalised to NULL. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Registering with Google did not persist the user's name.
google_callback(api/auth.py) only readidandemailfrom the Googleuserinforesponse and discardedgiven_name/family_name._find_or_create_userthen inserted the profile with onlyid+email, soprofiles.first_name/profiles.last_namestayedNULL.Fix
given_name/family_nameingoogle_callbackand pass them through_find_or_create_user.profiles.first_name/profiles.last_namecolumns (Phase 10.18 — no migration needed).COALESCE(profiles.<col>, EXCLUDED.<col>)so the name is only set when empty: a later Google login never overwrites a name the user edited. Empty incoming values normalise toNULL.Names live on
profiles(where every reader looks viafirst_name/last_name), notauth_users.Tests
New
api/tests/test_auth_google_name.py(fake-conn pattern fromtest_events.py): name reaches the profiles upsert; empty/whitespace names become NULL; no-name callers default to NULL; asserts the COALESCE guard is present. Full backend suite green (164 passed).🤖 Generated with Claude Code