Conversation
vladefr97
requested changes
Jun 7, 2023
| dockerfile: Dockerfile | ||
| restart: always | ||
| environment: | ||
| - SQLALCHEMY_DATABASE_URL=postgresql://${DB_USER}:12345@db/${DB_NAME} |
Collaborator
There was a problem hiding this comment.
лучше не хардкодить тут переменные 12345@db , все нужно через env файл задавать
| Base = declarative_base() | ||
|
|
||
| # Модель студента | ||
| class Student(Base): |
Collaborator
There was a problem hiding this comment.
Нужно вынести в отдельный файл с моделями
| students: List[StudentResponse] | ||
|
|
||
| # Подключение к базе данных | ||
| SQLALCHEMY_DATABASE_URL = "sqlite:///./test.db" |
Collaborator
There was a problem hiding this comment.
Нужно вынести в отдельный конфиг файл
| students: List[StudentResponse] | ||
|
|
||
| # Подключение к базе данных | ||
| SQLALCHEMY_DATABASE_URL = "sqlite:///./test.db" |
Collaborator
There was a problem hiding this comment.
У тебя же в docker-compose postgres, зачем здесь sqllite?
|
|
||
| # API эндпоинт для создания студента | ||
| @app.post("/students/") | ||
| def create_student(student: StudentCreate): |
Collaborator
There was a problem hiding this comment.
Нужно сделать один или несколько отдельных файлов с апишками
| group = db.query(Group).filter(Group.id == group_id).first() | ||
| if not group: | ||
| raise HTTPException(status_code=404, detail="Group not found") | ||
| return {"id": group.id, "name": group.name} |
Collaborator
There was a problem hiding this comment.
Возвращай pydantic схемы вместо словарей
vladefr97
approved these changes
Jun 8, 2023
| @@ -0,0 +1,5 @@ | |||
| DB_USER=postgres | |||
Collaborator
There was a problem hiding this comment.
.env нельзя в репозиторий заливать, там обычно секреты хранятся
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.