Icon Composer로 앱 로고를 넣습니다.#267
Merged
Merged
Conversation
- tuist: app icon Nmae 설정 - 전체 루트에 넣으면 tuist generate와 함께 로고가 사라지므로 ReSource 내부에 저장합니다.
Contributor
There was a problem hiding this comment.
Code Review
This pull request configures the app icon name to "ChaGok" in the project settings and adds the corresponding SVG asset and configuration files. Additionally, it comments out the debug error simulation blocks in both MLXModelProvider.swift and WhisperKitProvider.swift. The reviewer recommends removing these commented-out blocks entirely to improve code readability and maintainability, suggesting they be replaced with a TODO comment or controlled via custom compiler flags.
🛠️ Tuist Run Report 🛠️Tests 🧪
Builds 🔨
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 작업 요약
Icon Composer 앱 로고 적용(Tuist 설정) 및 디버그 모드 테스트 코드 임시 주석 처리
📋 구체적인 내용
ChaGok.icon폴더를App/Resources/내부로 이동하여tuist generate시에도 리소스 폴더가 유실되지 않고 Xcode 내비게이터에보존되도록 개선
Project.swiftTarget Settings(base)에ASSETCATALOG_COMPILER_APPICON_NAME을"ChaGok"으로 지정하여 Tuist 재생성 시에도앱 아이콘 빌드 설정이 영구 적용되도록 구축
디버그 모드 네트워크 실패 및
unknownError테스트 코드를 주석 처리App모듈 (앱 아이콘 리소스 및 Tuist 빌드 세팅)Data모듈 (디버그 모드 테스트 코드)🧩 설계·구현 노트
.xcodeproj)이 빌드 시점마다 새로 빌드되는 구조이므로, 수동 설정을 배제하고Project.swift설정과 리소스디렉토리(
Resources/**) 배치를 수정하여 빌드 환경을 자동화하고 견고히 함.✅ 확인 사항
tuist generate후 Xcode 상에서 리소스 유지 확인)👀 리뷰 포인트