폴더 이동 휴지통 폴더 조회 로직 수정합니다.#277
Merged
Merged
Conversation
- 기존 코드에서 휴지통 폴더가 id 필더링에서 살아있음을 발견. kind를 통해 kind != .trash를 확인합니다.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the MoveFolderListViewModel to filter out the trash folder when fetching the list of available destination folders for moving voice notes. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
🛠️ Tuist Run Report 🛠️Tests 🧪
Builds 🔨
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 작업 요약
.trash)가 노출되지 않도록 필터링을 추가했습니다.📋 구체적인 내용
MoveFolderListViewModel에서 이동 가능한 대상 폴더를 필터링할 때kind != .trash조건을 추가해 휴지통 폴더를 제외했습니다.MoveFolder모듈🔗 연관 이슈
🧩 설계·구현 노트
$0.id != currentFolderID)만으로는 휴지통 폴더가 걸러지지 않기 때문에, 명시적으로kind != .trash조건을 추가하여안전하게 제외했습니다.
✅ 확인 사항
👀 리뷰 포인트