Skip to content

Claude/modernize cruciallib j mjkf#5

Merged
Chafficui merged 3 commits intomasterfrom
claude/modernize-cruciallib-jMJKF
Feb 20, 2026
Merged

Claude/modernize cruciallib j mjkf#5
Chafficui merged 3 commits intomasterfrom
claude/modernize-cruciallib-jMJKF

Conversation

@Chafficui
Copy link
Copy Markdown
Member

No description provided.

claude and others added 3 commits February 20, 2026 09:32
…sts)

Expand test coverage from ~63 smoke tests to 178 meaningful behavioral
tests. New tests verify registration lifecycles, recipe creation, GUI
system logic, event handler flags, YAML I/O round-trips, and player
display utilities.

New test files:
- CrucialHeadTest: head construction, owner validation, registration
- ItemTest: recipe creation, key sanitization, recipe removal
- CrucialItemEventsTest: usable/crafting flag verification
- PageTest: GUI page sizing, item management, fill materials
- InventoryItemTest: constructors, movable flag, action execution
- YesNoButtonsPrefabTest: prefab item generation, action callbacks
- InterfaceTest: title/tablist/name display utilities
- BossbarTest: boss bar creation for players
- YamlTest: file creation, save/load round-trip, nested keys

Expanded existing tests:
- CrucialItemTest: 15 → 35 tests (full lifecycle, builder, flags)
- StackTest: 9 → 18 tests (shiny flag, item flags, player heads)

Source fixes for MockBukkit compatibility:
- Item.java, Bossbar.java: replace static Main.getPlugin() with lazy
  Bukkit.getPluginManager() lookup (avoids classloader mismatch)
- Item.java: skip Material.AIR in recipe ingredients
- Yaml.java: remove unused static plugin field

https://claude.ai/code/session_01YCncMJ53XbZ9QkjzTEespC
@Chafficui Chafficui merged commit 2cbc9d1 into master Feb 20, 2026
4 checks passed
@Chafficui Chafficui deleted the claude/modernize-cruciallib-jMJKF branch February 20, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants