data(schema): add provider lifecycle metadata columns - #3009
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
Errors per inputErrors in ./references/providers/providers.csv
Timeouts per inputTimeouts in ./references/providers/providers.csv
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: REQUEST_CHANGES
Risk: MEDIUM
Summary: The provider CSV stays structurally parseable and has no duplicate provider slugs, but the current-cycle link-check report found failures on provider rows this PR marks as active.
Findings: HIGH - references/providers/providers.csv row 123 and row 602 - btfs and swing are newly marked providerStatus=active, but the current-cycle link-check failed their existing provider URLs: https://www.btfs.io/, https://swing.xyz, and https://developers.swing.xyz/. Please fix or verify the provider URLs before marking these providers active, or leave their lifecycle status blank until the active status is source-backed by reachable official links.
Confidence: HIGH
|
Hi @aiirvizionz - this PR is stale and still has unresolved requested changes. Could you please address the review feedback and push an update when it is ready? |
63b6b54 to
802638f
Compare
|
Updated this branch onto the latest |
802638f to
d2855bb
Compare
|
Rebased onto current |
|
@USS-Supervisor The requested changes from the 2026-08-17 review have been fully addressed on current head |
Summary
Errors per inputErrors in ./references/providers/providers.csv
Timeouts per inputTimeouts in ./references/providers/providers.csv
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: COMMENT
Risk: LOW
Summary: The prior data-integrity concern is addressed: the branch now preserves all 720 provider rows exactly and only adds blank providerStatus and parentProvider columns. I am not approving this cycle because the current-cycle link-check report for the touched provider table still lists URL failures/timeouts, even though the workflow concluded successfully.
Findings: None blocking in the CSV data changes reviewed. Current-cycle link-check run 33279902364 reported 2521 successful links, 34 errors, 4 timeouts, and 0 unsupported URLs in references/providers/providers.csv, so the approval gate is not clean.
Confidence: HIGH
|
@aiirvizionz this PR is stale again after the last update, and the current blocker is still unresolved requested changes. Please address the review feedback and update the PR when ready. |
|
Follow-up on the prior requested changes: current head d2855bb leaves providerStatus blank for both �tfs and swing, preserving their existing URLs without marking them active. Isolated JSON validation and the latest link-check completed successfully; the earlier CHANGES_REQUESTED review targets an older head. Please re-review the current head when convenient. |
d2855bb to
5e2405f
Compare
|
Rebased onto current main and pushed 5e2405f to resolve the merge conflict. The file now preserves all 722 current provider rows and adds only blank providerStatus and parentProvider columns; btfs and swing remain unclassified. Local validate_csv.py passes and no tracked files outside the intended CSV changed. Please re-review the current head. |
Summary
Implements the data-shape portion of #2937 as the companion to the schema/tooling PR #3008.
Changes
providerStatusandparentProvidercolumns to all 720 provider rows currently onmain.mainunchanged.Verification
mainat5549a3a8.mainafter excluding the two new columns.providerStatusandparentProvidervalue is blank.git diff --checkpasses.This conservative migration resolves the earlier review finding:
btfsandswingare not marked active, and no provider receives an unsupported lifecycle assertion.Reward
If accepted under DBIP #2937, please use the project-owned EVM/USDC reward address:
0x769f7a238c8874148bcA1aE0736295630C28faF7.