fix(ci): validate main data with json tools - #3117
Conversation
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: COMMENT
Risk: LOW
Summary: The workflow diff is narrowly scoped and the current Validate JSON run completed successfully, including checkout of main source data, dependency installation from tools/requirements.txt, symlink preparation, JSON generation, and validation. I do not see a data-integrity issue in the changed workflow.
Findings:
- No blocking code finding from the visible workflow diff. I am leaving this as a non-approval review because the required review-cycle
link-checkgate could not complete for this PR: after addingcheck-links, no current-cycleLink Check (analysis)run appeared within the five-minute budget, likely because this PR targetsjson-tools, whose base workflow set does not include the link-check workflow.
Confidence: HIGH
|
Thanks for the review. This PR intentionally targets the The relevant validation completed successfully: it checked out the source data from Could you please advise whether any additional review step is needed for this branch-targeted CI fix, or whether the current successful validation is sufficient to proceed? |
|
@bcabreraike-cmyk this PR has been idle for more than 3 days after review feedback, and I do not see a newer commit addressing it. Please address the feedback and update the PR when ready. |
|
Update: I added the official Link Check (analysis) workflow from main to this branch. The updated Validate JSON check is passing. The Link Check job is currently skipped because this PR has no check-links label; the workflow is intentionally label-gated. Could a maintainer please apply the check-links label to trigger the required analysis? I also checked updating this branch against the current json-tools base. That update currently surfaces existing source-data reference conflicts, so I have not mixed unrelated data cleanup into this CI-focused PR. |
Summary
|
|
Update: this PR is now refreshed on the current
The prior label-gated deadlock is addressed for PRs targeting |
Summary
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Risk: LOW
Summary: The refreshed json-tools CI workflow now validates against main source data and includes the link-check workflow needed for the review-cycle gate. Required validation is green and the current-cycle Link Check (analysis) run completed successfully with a clean 0-URL summary for this workflow-only PR.
Findings: None.
Confidence: HIGH
Summary
Fixes the validation workflow so it checks the PR's json-tools code against the source data from
main.Type of change
Scope
Validation
mainand do not collide withjson-tools.git diff --check.