feat(sdks): fill vendor SDK metadata from each row's own documented package - #3233
feat(sdks): fill vendor SDK metadata from each row's own documented package#3233CodeRabbit-byte wants to merge 1 commit into
Conversation
…ackage Fills latestKnownVersion, latestKnownReleaseDate, maintainer and license on 10 vendor SDK rows across Tatum, Pinata, LI.FI and Wormhole. 37 placeholder cells, plus one correction. Each row's package was taken from the install command on the docs page that row already links, not inferred: @tatumio/tatum, pinata, @lifi/sdk and @wormhole-foundation/sdk. Values then come from the npm registry. Version metadata is identical across a vendor's pricing tiers because the published SDK does not vary by plan. Correction: lifi-sdk had license MIT. @lifi/sdk is Apache-2.0 on npm for every published version and on the lifinance/sdk repository. validate_csv.py: All checks passed.
Summary
|
USS-Supervisor
left a comment
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Risk: LOW
Summary: The PR is narrow to references/offers/sdks.csv and fills version/date/maintainer/license metadata for existing vendor SDK rows, with the only non-placeholder overwrite limited to the LI.FI license correction supported by package metadata. CSV parsing stays stable at 18 columns/158 rows, required validation passed, and the reviewer-owned current-cycle link-check run 32983724612 completed successfully with 6/6 successful links and 0 errors/timeouts/unknown/unsupported.
Findings: None.
Confidence: HIGH
|
Hi @eugene17kotov - this PR is stale, required CI is passing, and I don't see a blocking review. Could you please review when you have a chance? |
|
@eugene17kotov following up on this stale PR. Required CI is passing and I do not see a blocking review, so it still looks ready for reviewer action when you have a chance. |
2 participants
Fills
latestKnownVersion,latestKnownReleaseDate,maintainerandlicenseon 10 vendor SDK rows across Tatum, Pinata, LI.FI and Wormhole. 37 placeholder cells, plus one correction. 10 rows, one file.In #3232 I left the vendor pricing-tier rows alone because a docs link pointing at a family of SDKs does not identify a package. For these four vendors it turned out the linked page names the package outright, in its own install command — so the identification comes from the row, not from me.
tatum-sdk-free@tatumio/tatumtatum-sdk-pro@tatumio/tatumtatum-sdk-scale@tatumio/tatumtatum-sdk-starter@tatumio/tatumpinata-sdk-fiestapinatapinata-sdk-freepinatapinata-sdk-picnicpinatalifi-sdk@lifi/sdkwormhole-sdk-free@wormhole-foundation/sdkwormhole-sdk-usage@wormhole-foundation/sdkWhere the package name came from.
docs.tatum.io/docs/javascript-sdkgivesnpm install @tatumio/tatum.docs.pinata.cloud/sdk/getting-startedgivesnpm i pinata.docs.li.fi/sdk/overviewgivesnpm install @lifi/sdk.wormhole.com/docs/tools/typescript-sdk/get-started/givesnpm install @wormhole-foundation/sdk. All four are the URLs already sitting in those rows'actionButtons.Why tiers of the same vendor share a version. The published SDK does not vary by pricing plan —
tatum-sdk-freeandtatum-sdk-scaleinstall the same@tatumio/tatum. Repeating the version across a vendor's tiers is the accurate answer, not a copy-paste artefact.One correction, and I want to be explicit about it since it overwrites a real value rather than a placeholder.
lifi-sdkcarriedlicense=MIT.@lifi/sdkisApache-2.0: on npm for the current 4.5.0, on npm for every published version back to the earliest previews, and on thelifinance/sdkrepository itself. I checked all three before changing it. Everything else in this PR only touches cells reading exactlyTBD.Still deliberately untouched.
thirdweb-sdkandsequence-sdk-free— I fetched both linked docs pages and neither states a package name, so their rows keepTBD. Likewise the Web3Auth, Dfns, Blockdaemon, Dynamic, Magic and ConnectKit-adjacent tiers not covered here or in #3232.Safety of the edit. A scripted diff against
upstream/mainconfirms 10 lines changed, no width changes, nothing outside the four target columns, and no non-TBDcell altered except the single sanctionedlifi-sdklicence correction above.validate_csv.pyfrom thejson-toolsbranch:All checks passed.No links added or changed.Reward address:
0x1589423BeCC3F87EA9406155EaF4D5E04C34Dcf1(USDC/USDT, Ethereum mainnet)