Skip to content

data(filecoin): add Spade storage deal service - #3270

Open
aiirvizionz wants to merge 1 commit into
Chain-Love:mainfrom
aiirvizionz:data/filecoin-spade-service
Open

data(filecoin): add Spade storage deal service#3270
aiirvizionz wants to merge 1 commit into
Chain-Love:mainfrom
aiirvizionz:data/filecoin-spade-service

Conversation

@aiirvizionz

Copy link
Copy Markdown
Contributor

Summary

  • Add Spade as a canonical provider and service offer.
  • Add the corresponding Filecoin services listing.
  • Keep the change scoped to one provider -> offer -> network listing chain.

Sources

The source repository is public and not archived. The separate api.spade.storage endpoint was deliberately not added because it currently redirects to itself; this PR only includes links that resolve successfully.

Validation

  • Both included source URLs return HTTP 200.
  • No existing open or closed Chain-Love PR for Spade was found before implementation.
  • validate_csv.py: passed.
  • csv_to_json.py: passed (only pre-existing network warnings).
  • validate.py: passed for every generated network JSON.
  • git diff --check: passed.
  • Final diff: exactly three inserted CSV rows in three files.

Reward

Project-owned payout address: 0x769f7a238c8874148bcA1aE0736295630C28faF7

No social bonus is claimed.

AI disclosure

AI assistance was used to research the current official sources, prepare the narrowly scoped CSV entries, and run the repository validation suite. All source links and generated output were verified before submission.

Copilot AI lite review requested due to automatic review settings August 28, 2026 06:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@aiirvizionz

Copy link
Copy Markdown
Contributor Author

The isolated validation check passed. The repository link-check workflow was skipped because this fork PR does not have the check-links label. Could a maintainer please apply that label so the two official source URLs can be checked by CI? Both URLs currently return HTTP 200.

@github-actions

Copy link
Copy Markdown

Summary

Status Count
🔍 Total 4
🔗 Unique 2
✅ Successful 4
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 0
❓ Unknown 0
🚫 Errors 0
⛔ Unsupported 0

Full Github Actions output

@USS-Supervisor USS-Supervisor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: COMMENT
Risk: LOW
Summary: The three added Filecoin service rows are structurally consistent, with stable CSV widths, a unique spade provider/offer/listing slug, and a listing that resolves through !offer:spade. I cannot approve this cycle because the required current-cycle link-check run did not appear within the five-minute reviewer window after check-links was applied.
Findings: None.
Confidence: MEDIUM

@aiirvizionz

Copy link
Copy Markdown
Contributor Author

The current head d865bc7 now has both required checks completed successfully: Generate JSON and validate (isolated) passed, and the reviewer-triggered link-check run 33150148697 passed with 4/4 links and no errors or timeouts. The earlier review comment appears to have missed that completed run. Could you please re-review this PR when convenient? No additional author-side code change is pending.

@github-actions

Copy link
Copy Markdown

Summary

Status Count
🔍 Total 4
🔗 Unique 2
✅ Successful 4
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 0
❓ Unknown 0
🚫 Errors 0
⛔ Unsupported 0

Full Github Actions output

USS-Supervisor
USS-Supervisor previously approved these changes Aug 29, 2026

@USS-Supervisor USS-Supervisor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE
Risk: LOW
Summary: The PR remains narrowly scoped to one Filecoin provider, offer, and listing row. Required validation is passing, the listing !offer:spade resolves to the canonical service offer, CSV widths are stable, and the current-cycle link-check passed with 4/4 links and 0 errors.
Findings: None.
Confidence: HIGH

@aiirvizionz

Copy link
Copy Markdown
Contributor Author

@eugene17kotov Could you please review the current approved/green batch when convenient: #3270, #3271, #3284, and #3285? Each PR is mergeable, has successful isolated validation and link-check, and has an APPROVED verdict from USS-Supervisor with no findings. GitHub still reports REVIEW_REQUIRED because the automated approval does not satisfy the write-access review rule, and the contributor account cannot add a requested reviewer through the API. No author-side changes are pending on these four PRs.

@USS-Supervisor

Copy link
Copy Markdown
Member

@eugene17kotov this PR has been idle for more than 3 days. Required CI is passing and I do not see a blocking review, so it looks ready for your review when you have a chance.

@USS-Supervisor USS-Supervisor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: COMMENT
Risk: LOW
Summary: Required validation is passing and the Filecoin Spade provider-offer-listing relationship remains coherent, but the current review-cycle link-check did not spawn for this PR within the five-minute budget after check-links was added. I cannot approve without a current-cycle link-check result.
Findings: No data-specific blocker posted in this review. Please request review again after a fresh link-check run is available for the current head.
Confidence: MEDIUM

@aiirvizionz
aiirvizionz force-pushed the data/filecoin-spade-service branch from d7ea84c to d636403 Compare September 4, 2026 16:46
@aiirvizionz

Copy link
Copy Markdown
Contributor Author

Rebased onto current main and pushed d636403 to resolve the merge conflict. The Spade provider, offer, and listing rows remain present without duplicate offer slugs; isolated validation now passes. Please re-review the current head.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants