data(filecoin): add Spade storage deal service - #3270
Conversation
|
The isolated validation check passed. The repository link-check workflow was skipped because this fork PR does not have the |
Summary
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: COMMENT
Risk: LOW
Summary: The three added Filecoin service rows are structurally consistent, with stable CSV widths, a unique spade provider/offer/listing slug, and a listing that resolves through !offer:spade. I cannot approve this cycle because the required current-cycle link-check run did not appear within the five-minute reviewer window after check-links was applied.
Findings: None.
Confidence: MEDIUM
|
The current head d865bc7 now has both required checks completed successfully: Generate JSON and validate (isolated) passed, and the reviewer-triggered link-check run 33150148697 passed with 4/4 links and no errors or timeouts. The earlier review comment appears to have missed that completed run. Could you please re-review this PR when convenient? No additional author-side code change is pending. |
Summary
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Risk: LOW
Summary: The PR remains narrowly scoped to one Filecoin provider, offer, and listing row. Required validation is passing, the listing !offer:spade resolves to the canonical service offer, CSV widths are stable, and the current-cycle link-check passed with 4/4 links and 0 errors.
Findings: None.
Confidence: HIGH
|
@eugene17kotov Could you please review the current approved/green batch when convenient: #3270, #3271, #3284, and #3285? Each PR is mergeable, has successful isolated validation and link-check, and has an APPROVED verdict from USS-Supervisor with no findings. GitHub still reports |
|
@eugene17kotov this PR has been idle for more than 3 days. Required CI is passing and I do not see a blocking review, so it looks ready for your review when you have a chance. |
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: COMMENT
Risk: LOW
Summary: Required validation is passing and the Filecoin Spade provider-offer-listing relationship remains coherent, but the current review-cycle link-check did not spawn for this PR within the five-minute budget after check-links was added. I cannot approve without a current-cycle link-check result.
Findings: No data-specific blocker posted in this review. Please request review again after a fresh link-check run is available for the current head.
Confidence: MEDIUM
d865bc7 to
d7ea84c
Compare
d7ea84c to
d636403
Compare
|
Rebased onto current main and pushed d636403 to resolve the merge conflict. The Spade provider, offer, and listing rows remain present without duplicate offer slugs; isolated validation now passes. Please re-review the current head. |
Summary
Sources
The source repository is public and not archived. The separate
api.spade.storageendpoint was deliberately not added because it currently redirects to itself; this PR only includes links that resolve successfully.Validation
validate_csv.py: passed.csv_to_json.py: passed (only pre-existing network warnings).validate.py: passed for every generated network JSON.git diff --check: passed.Reward
Project-owned payout address:
0x769f7a238c8874148bcA1aE0736295630C28faF7No social bonus is claimed.
AI disclosure
AI assistance was used to research the current official sources, prepare the narrowly scoped CSV entries, and run the repository validation suite. All source links and generated output were verified before submission.