Skip to content

feat(validation): enforce canonical wallet language tags - #3601

Open
bcabreraike-cmyk wants to merge 2 commits into
Chain-Love:json-toolsfrom
bcabreraike-cmyk:codex/dbip-3594-language-validator
Open

feat(validation): enforce canonical wallet language tags#3601
bcabreraike-cmyk wants to merge 2 commits into
Chain-Love:json-toolsfrom
bcabreraike-cmyk:codex/dbip-3594-language-validator

Conversation

@bcabreraike-cmyk

Copy link
Copy Markdown
Contributor

Summary

  • add a pinned IANA language-subtag snapshot for offline BCP 47 validation
  • reject malformed, non-canonical, ambiguous, and duplicate wallet language tags
  • add focused validation fixtures and run them in CI
  • document the canonical language format in the schema

Validation

  • python -m unittest discover -s tools/tests -p 'test_*.py'
  • python -m py_compile tools/validate_csv.py tools/tests/test_validate_csv.py
  • full CSV to JSON to JSON Schema validation passed locally; only pre-existing network-chain warnings remain

Dependency

This companion tooling change should be merged before the data update PR targeting main.

Closes #3594

@bcabreraike-cmyk
bcabreraike-cmyk force-pushed the codex/dbip-3594-language-validator branch from 980b4e3 to c828ef0 Compare September 3, 2026 22:20
@bcabreraike-cmyk
bcabreraike-cmyk force-pushed the codex/dbip-3594-language-validator branch from c828ef0 to 2a7cf04 Compare September 3, 2026 22:20
@bcabreraike-cmyk

Copy link
Copy Markdown
Contributor Author

CI update: the validation workflow was corrected to use the actual json-tools paths, install tools/requirements.txt, run the tooling fixtures, and compile the package. The new GitHub check now passes. No secrets or reward address were added.

@USS-Supervisor USS-Supervisor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: COMMENT
Risk: LOW
Summary: The json-tools language-tag validator change is focused and internally consistent from the diff I inspected. Required Validate json-tools / Validate tooling is passing, and the focused local unittest and py_compile checks passed in a temporary worktree.
Findings: None from static review. Gate note: I added check-links at 2026-09-03 23:08:58 UTC and polled for the five-minute budget, but no current-cycle Link Check (analysis) run appeared for this PR. I removed check-links before submitting this review, so approval should wait for a fresh successful current-cycle link-check.
Confidence: MEDIUM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants