Skip to content

bench pages: never cache a degraded 'no live data' render #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Jul 10, 2026
Merged

bench pages: never cache a degraded 'no live data' render #1039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/app/benchmarks/[slug]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Suspense } from "react";
import type { Metadata } from "next";
import { unstable_noStore as noStore } from "next/cache";
import { notFound } from "next/navigation";
import Link from "next/link";
import { ArrowLeft, ArrowUpRight, ChevronDown } from "lucide-react";
Expand Down Expand Up @@ -210,6 +211,14 @@ export default async function BenchmarkPage({

const isDraft = benchmark.status === "draft";
const isAwaiting = isDraft && benchmark.editorialStatus === "live";
// An editorially-live bench rendering as draft means the store read
// came back empty this cycle (srh timeout, snapshot swap), not that
// the bench has no data: keep that render OUT of the ISR cache so the
// next visitor triggers a fresh read instead of everyone seeing
// "no live data yet" for a revalidate window (seen on perp-fees
// 2026-07-10). Genuinely-new benches render dynamically until their
// first samples land, which is the correct behavior anyway.
if (isAwaiting) noStore();
// Insufficient: editorially live, runtime might say "live" too, but the
// shared predicate decided no provider has a usable p50. Drives the
// pill above the H1 and the headline degradation downstream.
Expand Down
Loading