Skip to content

audit round 2: gram methodology, buyback percent + success - #1107

Merged
Flotapponnier merged 1 commit into
devfrom
fix/finality-buyback-audit
Jul 11, 2026
Merged

audit round 2: gram methodology, buyback percent + success#1107
Flotapponnier merged 1 commit into
devfrom
fix/finality-buyback-audit

Conversation

@Flotapponnier

Copy link
Copy Markdown
Collaborator

Three findings from the continued audit, each verified before changing:

  1. Gram finality 0.4s is CORRECT (empirically measured 0.42s/block; masterchain is BFT-final at production since the accelerated upgrade) but the methodology text described a 3-seqno lookback the measurement does not use. Text now describes the real measurement; the external reference claiming ~2.7s/block is pre-upgrade.
  2. buyback-audit rendered raw fractions with a percent sign (Hyperliquid 0.94%): ratios now scaled x100 in queries, page reads 94%.
  3. Sky success showed 0% while its data was live and fresh: the formula multiplied any scrape error rate by 300, and coingecko throttling (327 lifetime errors, price still cached fine) zeroed it. Success is now scrape freshness (last success within 2h), matching what the column claims to mean.

…rement, buyback ratios scaled to percent, buyback success is scrape freshness (coingecko error counter zeroed sky at x300)
@Flotapponnier
Flotapponnier merged commit 38e96d5 into dev Jul 11, 2026
@Flotapponnier
Flotapponnier deleted the fix/finality-buyback-audit branch July 17, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant