hotfix: tripwire fires only when every appearance claims live - #1271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#1262 tightened the tripwire so it would skip when every appearance was `unresponsive` or `unavailable` — but that didn't cover Cloudflare's shape. Cloudflare's live results carry `availability: "live"` for benches where the harness got some response (even a -32046 error counts as a response with success=0), while other benches show `availability: "unavailable"`. Mixed → `allUnresponsive === false` → tripwire fires → `/products/cloudflare` 500 → smoke fails → auto-rollback.
Result: prod-deploy has been in a rollback loop for 25h+. Every push to main gets reverted. #1256 SEO pack, #1258/#1259 ticker clamps, #1262 tripwire pass 1, #1268 cosmos-hub — all queued behind this.
Fix
Invert the exception. The true store-read-failure signature is "every appearance claims `availability: 'live'` yet none of them ranked" — that's the case ISR shouldn't cache. Any mix that includes an `unavailable`/`unresponsive` row is legitimate provider data (some benches fine, others down for real reasons), not a store fault. Render as-is, don't 500.
Same throw, narrower trigger.
Blocked queue behind this