Skip to content

hotfix: tripwire fires only when every appearance claims live - #1271

Merged
Flotapponnier merged 1 commit into
mainfrom
hotfix/tripwire-only-fire-on-live
Jul 17, 2026
Merged

hotfix: tripwire fires only when every appearance claims live#1271
Flotapponnier merged 1 commit into
mainfrom
hotfix/tripwire-only-fire-on-live

Conversation

@Flotapponnier

Copy link
Copy Markdown
Collaborator

Why

#1262 tightened the tripwire so it would skip when every appearance was `unresponsive` or `unavailable` — but that didn't cover Cloudflare's shape. Cloudflare's live results carry `availability: "live"` for benches where the harness got some response (even a -32046 error counts as a response with success=0), while other benches show `availability: "unavailable"`. Mixed → `allUnresponsive === false` → tripwire fires → `/products/cloudflare` 500 → smoke fails → auto-rollback.

Result: prod-deploy has been in a rollback loop for 25h+. Every push to main gets reverted. #1256 SEO pack, #1258/#1259 ticker clamps, #1262 tripwire pass 1, #1268 cosmos-hub — all queued behind this.

Fix

Invert the exception. The true store-read-failure signature is "every appearance claims `availability: 'live'` yet none of them ranked" — that's the case ISR shouldn't cache. Any mix that includes an `unavailable`/`unresponsive` row is legitimate provider data (some benches fine, others down for real reasons), not a store fault. Render as-is, don't 500.

Same throw, narrower trigger.

Blocked queue behind this

@Flotapponnier
Flotapponnier merged commit d3d54ba into main Jul 17, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant