TimeSeriesChart: forward chain prop to /api/series so chain tab switch re-fetches - #1274
Merged
Merged
Conversation
added 2 commits
July 17, 2026 17:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: on a bench with dimensions.chain (aggregator-head-lag, metadata-coverage, …), clicking a different chain tab keeps the 7d/30d sparkline stuck on whichever chain was loaded first. The 24h sparkline updates (server-rendered per chain via viewBenchmark) but the lazy-fetched longer ranges don't.
Root cause in
src/components/time-series-chart/index.tsx:buildQsonly forwardedregion, neverchain.useEffectdeps were[regionProp, benchmark.slug]— no chain — so a chain change triggered no re-fetch.The
/api/series/[slug]endpoint already accepts and honors?chain=(route.ts:130 iterates["chain","region","kind","venue"]), so the fix is purely client-side wiring.Change
TimeSeriesChartgainschain?: stringprop mirroringregion?: string.buildQssetschainwhen the prop is set and not "all".useEffectdeps includechainPropso a chain tab flip triggers the re-fetch.BenchmarkBodypasseschain={effectiveChain ?? undefined}down.Test plan