share-card: flexShrink:0 on title/subtitle (fix Satori collapse under flex:1 sibling) - #1276
Merged
Conversation
…them under sibling flex:1
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long-title benches (rpc-capabilities, 96 chars) had title text visually overlapping leaderboard rows and snapshot subtitle even after PR #1275 font-size scaling.
Root cause: Satori's yoga layout applies default
flex-shrink: 1to flex-column children. When a sibling hasflex: 1(leaderboard rows container), Satori collapses the 2-line title's height to fit, but the text still renders at its true multi-line height, painting over the next sibling.Fix:
flexShrink: 0on title + subtitle divs in ranking, leaderboard, snapshot, compare templates forces Satori to reserve the true content height.