Skip to content

share-card: shrink snapshot chart to fit 2-row legend #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Jul 17, 2026
Merged

share-card: shrink snapshot chart to fit 2-row legend #1284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/app/benchmarks/[slug]/share-card/route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,7 +1004,11 @@ async function renderSnapshot(
.filter((s) => s.values.length > 1);

const chartW = 1086;
const chartH = 280;
// 280 was too tall - the legend routinely wraps to 2 rows and
// overlaps the footer on wide-cohort benches (rpc-capabilities 13,
// ethereum-rpc 8, perp-fees 8). 220 leaves ~60px more for 2 legend
// rows to fit above the footer.
const chartH = 220;
const all = seriesList.flatMap((s) => s.values);
const min = all.length ? Math.min(...all) : 0;
const max = all.length ? Math.max(...all) : 1;
Expand Down
Loading