Skip to content

spec: unstable_noStore() on draft-placeholder fallback (kill poisoned aggregate) #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Jul 18, 2026
Merged

spec: unstable_noStore() on draft-placeholder fallback (kill poisoned aggregate) #1288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/lib/spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*/

import { cache } from "react";
import { unstable_cache } from "next/cache";
import { unstable_cache, unstable_noStore } from "next/cache";
import type { Benchmark } from "@/types/benchmark";
import type { Spec } from "@/lib/spec-schema";
// Imported from the isolated alias module (NOT @/lib/chains) to avoid
Expand Down Expand Up @@ -483,6 +483,16 @@ export const loadAllBenchmarksSafe = cache(
return await loadAllBenchmarksCached();
} catch (err) {
if (err instanceof AllBenchmarksDraftError) {
// Opt this render out of every cache layer (ISR + CDN edge). When
// the aggregate quorum is lost (SRH stuck, Redis blackout, worker
// starved) the placeholder response is a degraded surrogate, NOT
// ground truth. Without noStore the placeholder HTML would sit at
// Vercel Edge for `revalidate` seconds and — under stale-while-
// revalidate — for hours after backend recovery, since SWR only
// refreshes on cache miss. Marking the response no-store forces
// every subsequent hit to re-render, which immediately picks up
// real data as soon as SRH is back — no cache-key bump, no deploy.
unstable_noStore();
const specs = await loadSpecs();
return specs
.map((s) => draftPlaceholderForSpec(s))
Expand Down
Loading